-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: extend reservation nominator to support reservation preemption #1936
scheduler: extend reservation nominator to support reservation preemption #1936
Conversation
b0f68f6
to
bd79061
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
==========================================
+ Coverage 67.45% 67.47% +0.01%
==========================================
Files 420 420
Lines 46849 46944 +95
==========================================
+ Hits 31603 31674 +71
- Misses 12945 12966 +21
- Partials 2301 2304 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bd79061
to
f07c4a5
Compare
pkg/scheduler/frameworkext/eventhandlers/reservation_handler.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/frameworkext/testing/fake_reservation_nominator.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/frameworkext/testing/fake_reservation_nominator.go
Outdated
Show resolved
Hide resolved
49dcbe3
to
5970645
Compare
…tion Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
5970645
to
f21b4d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@buptcozy Please take a look.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…tion (koordinator-sh#1936) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Ⅰ. Describe what this PR does
Extend the reservation nominator. Reservation plugin implements the BeforeFilter function. In this function, we do add the nominated reservation infos.
Ⅱ. Does this pull request fix one issue?
fix #1935
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test